🐛 incomplete function chain and renamed function in list-compatibl… #1546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
openshift-ci
bot
added
lgtm
|
New changes are detected. LGTM label has been removed. |
…e-bundles hack script
azych
force-pushed
the
fix-list-compatible-bundles-script
branch
from
bf65b09 to
d5b142a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1546 +/- ##
=======================================
Coverage 74.25% 74.25%
=======================================
Files 42 42
Lines 3329 3329
=======================================
Hits 2472 2472
Misses 676 676
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 8, 2025
…e-bundles hack script (operator-framework#1546) Co-authored-by: Artur Zych <[email protected]>
camilamacedo86
pushed a commit
to camilamacedo86/operator-controller
that referenced
this pull request
Jan 8, 2025
…e-bundles hack script (operator-framework#1546) Co-authored-by: Artur Zych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix to the hack/tools/catalogs/list-compatible-bundles script that adds the missing
extract-olm-package-propertyfunction to the call chain and uses the correct name of regex filtering function (filter-by-regex-if-necessary), making sure the script works.The main issues here were two:
1.
regex_itdid not exist and was renamed during review of the original PR tofilter-by-regex-if-necessary2.
extract-olm-package-propertycall was missing from the chain meaning the filter function couldn't recognize the structure it was expectingBefore change result:
After change result:
Separated from #1539 as per #1539 (comment)
Reviewer Checklist